Fixing Path of Exile's Mangled Text Bug

"

Trilkk wrote:

"

Googlenysh wrote:

Am I the only one bothered by the idea that SCRIPT_CACHE* still isn't unloaded from the memory, even if you unloaded the font? :)

Thinking of exactly the same thing. If the SCRIPT_CACHE is allocated here and never removed, doesn't this mean that unloading and reloading fonts would endlessly allocate new SCRIPT_CACHE objects that never experience cleanup.

From the bug we all encountered, we know that it did not crash PoE, the cache always still existed. From this perspective, the quote:

"

...there were a few ways to go about fixing this: You could move the SCRIPT_CACHE object to belong to the Resource::Font object, delete the old SCRIPT_CACHE whenever the font gets unloaded, or swap the lookup value from the memory address to be instead be based on the typeface, size and styling of the font, which is what actually makes a font unique. All these options work but each has its own pros and cons and should be weighed based on how it fits into the larger systems.

seems a bit dubious. I have no idea how large the caches are, but if we take the explanation at face value, all solutions that are not "delete the old SCRIPT_CACHE whenever the font gets unloaded" end up slowly leaking memory.

Of course, if the cache would be keyed on the font identity and settings, there would be some theoretical maximum amount of elements in the cache. But it still sounds kind of dubious.

Could I please get a clarification on this?