Sacrifice skill gem spirit calculation.

SSF

Sacrifice equipped with clarity2, upwelling2, vitality2.
Possible interactions with skeletal warriors from septre, and ancestral ancestor spectre. Thats a mouthfull.

This happens loading into the game, and loading into maps. I'll notice I have too much spirit on my bar.

I open my skills, click on vitality2 as if to move it, then put it back in. Then sacrifice turns back on and everything is fine.

If I remove the skill gem itself, the issue does not resolve. By that I mean clicking as if to move on the gem, and just clicking it back in. This doesn't trigger a recalculation, so the issue remains.

Another concerning factor of this, is that it seems this means the spirit calculation on loading into the game, and loading into maps... perhaps character loading or something- is different than the functionality that runs when removing and adding a support gem. As that clearly works.

This means crossover code performing duplicate functionality, which is bad. It also means possible siloing of teams, or programmers not properly finding already existing functionality and utilitzing. It could also mean programmers taking shortcuts instead of refactoring- in a case where the functionality is super close to what they need, but they would need to refactor it.

This saves time, now. It penalizes time down the road, and it makes maintenance more difficult in perpetuity. I manage a lot of codebases- this type of behavior, regardless of cause or nature, will cost dearly in the long run.

Good news, I did a little debugging to help resolve this easier. Easily narrowed it down quite a bit.

The only way the spirit calculation calculated correctly, is by removing the vitality2 skillgem and reapplying.

You may need to have other spirit calculations taking place to get it to bug... which I'll check... sec.

It does happen leaving and entering a map, both directions. In all cases, from map to endgame origin area or reverse, the miscalculation happens. Then can be resolved by removing and applying the vitality2 gem in all cases; but always is broken again once loaded in.


My goodness, its more complicated than I thought. I also didn't include a needed piece of the puzzle. I also have cast on minion death equipped. On, with

This only happens if you have cast on minion death(detonate dead, unleash), BEFORE Sacrifice in the skill gem order list.

Pfff. This means that something about cast on minion deaths spirit calculation, when afterwards being interacted with sacrifice and vitality2(maybe 1 as well) support... turns off sacrifice.

Geezum, ok so do the supports on sacrifice do anything, or is it just vitality2... ohhhh k, this is too much of an edge case.


After moving cast on minion death and sacrifice skill order, and removing adding supports to both- and swapping out the orders of supports; and then putting them back to how I had them... the bug no longer exists.

I can have the skills in either order, whatever the calculation was tripping over was reset. Certainly a bug, somehow, but certainly not worth chasing.