Stash Tab API is extremely inefficient.

Edit - don't get me wrong, i love the trade improvements.
But the current way they are programmed may cause problems.

First of all - you can become familiar with Public stash API here:
www.reddit.com/r/pathofexiledev/comments/48i4s1/information_on_the_new_stash_tab_api/

I'll get right to the main issue:
When a change is made to a stash, the entire stash is sent in an update

Let's talk some numbers:
One stash tab can contain 144 items. (items that take up a single slot)
Information about one item on average equals 800-1200 bytes
Therefore sending information about the entire stash tab can take up to 144KB

What does this mean you ask?
This means a single malicious person can substantially slow the network by filling up 20 premium stash tabs with alteration shards and swapping one in each tab every 10 seconds.

Every single indexer that uses public stash tab API will be forced to download 144KB*20 = 3MB of data every 10 seconds. (data that contains nothing but alteration shards)

A simple fix would be only sending the updated item not the entire stash tab.

Stash updates are sent every 2-3 minutes or once you zone out, not everytime you move something around.

Oh sure, just tell everybody about my plan for world domination. Thanks a lot.


Seriously though, good point. I'll have to take your word for the technical part of it because I don't know how the API works. Or even what API stands for.

"

Mannoth wrote:

Stash updates are sent every 2-3 minutes or once you zone out, not everytime you move something around.

Stash tab updates can be forced by going in and out of hideout.

Moving in and out of hideout doesn't take more than 10 seconds.

sooooo if someone wants to be a dick then they will do so...

nothing real new to the PoE world...

Indeed, this would be a serious abuse opportunity. But I suspect that GGG have some brains and can simply add some (per account? per stash tab?) rate limiting mechanism, thus cutting this kind of abuse off at the very source.

We'll just have to see how it plays out when the new system "hits production".

"

mark1030 wrote:

what API stands for.

API = Actual Programmed Internals. It's a professional term means the "guts" of the system what u can fiddle around with.

......... Y'know ... to make source codes. Ones and zeroes. Intarnet.

"

xSTGx wrote:

"

mark1030 wrote:

what API stands for.

API = Actual Programmed Internals. It's a professional term means the "guts" of the system what u can fiddle around with.

......... Y'know ... to make source codes. Ones and zeroes. Intarnet.

I thought it meant Application Program Interface? The thing that external developers can use for their applications to interface with the program?

How about they delay it to the same refresh rate the forums get crawled >:)?

Peace,

-Boem-

"

_Interrupt_ wrote:

First of all - you can become familiar with Public stash API here:
www.reddit.com/r/pathofexiledev/comments/48i4s1/information_on_the_new_stash_tab_api/

I'll get right to the main issue:
When a change is made to a stash, the entire stash is sent in an update

Let's talk some numbers:
One stash tab can contain 144 items. (items that take up a single slot)
Information about one item on average equals 800-1200 bytes
Therefore sending information about the entire stash tab can take up to 144KB

What does this mean you ask?
This means a single malicious person can substantially slow the network by filling up 20 premium stash tabs with alteration shards and swapping one in each tab every 10 seconds.

Every single indexer that uses public stash tab API will be forced to download 144KB*20 = 3MB of data every 10 seconds. (data that contains nothing but alteration shards)

A simple fix would be only sending the updated item not the entire stash tab.

This is a good point. It doesn't excuse the clickbait, exaggerated thread title, but the issue here is legit and I hope GGG implements a solution similar to yours regardless.