Curse on hit not working

Hello my curse on hit isn't working any suggestions?

Herald of Ice only applies curses when you shatter enemies, and then they only hit nearby enemies if they're still alive. In general, it's not actually consistent at all, and that inconsistency might be making it look like it's not working.

what would be better to use?

Something you use manually. Depends what your build is, but Leap Slam, Reave, Split Arrow and Ball Lightning are popular choices for various builds.

Strong ranged crit builds that can consistently shock typically use herald of thunder for offensive cursing because it's the only practical autocurse setup that can curse enemies on sight, without getting hit and they often clear too fast to get hit a lot.

Builds that clear slower and get hit more tend to use low level cwdt combined with a low level main spell, high level curse of choice and curse on hit. If the curse gains little by levelling (warlord's mark) often only cwdt is used.

I was following this guide for 1 month sc

https://www.pathofexile.com/forum/view-thread/1147951/page/1

I'm using Herald of Thunder + Curse on Hit + Assassin's Mark on my CoC Shadow character MasterBLB,and that works marvelously.The only issue for you will be range,these lightning striking around are more suited for melee character.Anyway,if your enemies are usually up to 1/3 of screen away of you try to switch heralds and see how it works for you.

I see unique ring Call of the Brotherhood is required for proper working of the Herald of Ice,do you have one?

I've checked that guide,and you are pretty near to Celestial Judgment and Punishment.I advise you to pick these.But that after you'll take Freeze from Shadow's area in case you have the above ring.

And the last,Arc setup.I'd drop Faster Casting for Increased Critical Damage.