Battlemage not adding damage to herald of thunder or herald of ice

battle mage does not add damage to either of these heralds. added dmg supports work(tested with added lightning damage support), added dmg from my gloves work(painseeker), but nothing from any weapon in main hand.

have not tried other heralds as i do not think they benefit from added dmg.

this seems similar to other peoples issues with battlemage, not applying to enchanted gloves for example.

thanks and keep up the good work!

It states that heralds are not affected by modifiers to spell damage; battlemage specifically states "gain added spell damage equal to the damage of your main hand weapon"

Read the skill gems word for word, taking everything it says literally and you will never come to these issues.