Endless Hunger "Life Leech effects are not removed at Full Life" doesn't work with Ghost Reaver / ES

Ghost Reaver makes life leech apply to ES instead. This inherently means that those leech effects are already not removed at full life (otherwise CI couldn't use GR). They're removed at full ES.

Endless Hunger only says it stops them being removed at full life (and with GR, they already aren't) it doesn't say anything about preventing them being removed at full ES.

"

joachimbond wrote:

Y'all just don't want to do the work to fix it. I get that.

The only reason I don't want to fix it is that it isn't broken. This is the correct and intended behaviour.

Standardising the wording of on-kill and on-hit effects (with particular regard to Headhunter, which is an annoying exception), is scheduled for a rework in the medimum-term. No ETA, as other stuff takes priority, but we definitely want to fix and improve those cases.

One of the basic properties of leech is that it stops when the thing it's applying to (be that life, mana, or ES) is full.
Applying life leech to ES means it's applying to ES, and so stops at full ES. It is no longer applying to life, so does not stop at full life.

"

i3igpete wrote:

Just for clarity, here is the argument in a nutshell. Ghost Reaver effectively changes 3 variables of Endless Hunger.

"

20% of Overkill Damage is Leeched as (1)Life
Life Leech effects (2)are not removed at Full (3)Life

1=life/ES
2=are/are not
3=life/ES

Current implementation of GR changes the behavior of variables 1, 2, and 3 so that EH effectively reads like this:

"

20% of Overkill Damage is Leeched as (1)ES
Life Leech effects (2)are removed at Full (3)ES

This is not at all the case. Ghost Reaver does absolutely nothing to what you've labelled as part (2). It does exactly what it says - your life leech effects grant you ES instead of life - this inherently means they are removed at full ES, because leech effects are always removed when the resource they grant is full. It does not change "full life" to "full energy shield" on endless hunger, because "life leech" and "full life" are different concepts, and it doesn't say anything about doing that.

Endless Hunger specifically provides an exception for removing life leech effects at full life. It does not say anything about them being removed at full ES, so does not affect that.